feat: add local skill store and targets
This commit is contained in:
69
internal/targets/junction_windows.go
Normal file
69
internal/targets/junction_windows.go
Normal file
@@ -0,0 +1,69 @@
|
||||
package targets
|
||||
|
||||
import (
|
||||
"errors"
|
||||
"fmt"
|
||||
"os"
|
||||
"os/exec"
|
||||
"path/filepath"
|
||||
"strings"
|
||||
)
|
||||
|
||||
func CreateJunction(linkPath, targetPath string) error {
|
||||
if err := os.MkdirAll(filepath.Dir(linkPath), 0o755); err != nil {
|
||||
return err
|
||||
}
|
||||
cmd := exec.Command("cmd.exe", "/c", "mklink", "/J", linkPath, targetPath)
|
||||
out, err := cmd.CombinedOutput()
|
||||
if err != nil {
|
||||
return fmt.Errorf("create junction failed: %w: %s", err, strings.TrimSpace(string(out)))
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
func ReadJunctionTarget(linkPath string) (string, error) {
|
||||
if _, err := os.Lstat(linkPath); err != nil {
|
||||
return "", err
|
||||
}
|
||||
target, err := os.Readlink(linkPath)
|
||||
if err == nil && target != "" {
|
||||
return cleanWindowsLinkTarget(target), nil
|
||||
}
|
||||
evaluated, evalErr := filepath.EvalSymlinks(linkPath)
|
||||
if evalErr != nil {
|
||||
return "", evalErr
|
||||
}
|
||||
if samePath(evaluated, linkPath) {
|
||||
return "", errors.New("path is not a junction")
|
||||
}
|
||||
return evaluated, nil
|
||||
}
|
||||
|
||||
func RemoveJunction(linkPath string) error {
|
||||
if err := os.Remove(linkPath); err == nil || errors.Is(err, os.ErrNotExist) {
|
||||
return nil
|
||||
}
|
||||
cmd := exec.Command("cmd.exe", "/c", "rmdir", linkPath)
|
||||
out, err := cmd.CombinedOutput()
|
||||
if err != nil {
|
||||
return fmt.Errorf("remove junction failed: %w: %s", err, strings.TrimSpace(string(out)))
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
func cleanWindowsLinkTarget(target string) string {
|
||||
target = strings.TrimPrefix(target, `\??\`)
|
||||
return filepath.Clean(target)
|
||||
}
|
||||
|
||||
func samePath(left, right string) bool {
|
||||
leftAbs, leftErr := filepath.Abs(cleanWindowsLinkTarget(left))
|
||||
rightAbs, rightErr := filepath.Abs(cleanWindowsLinkTarget(right))
|
||||
if leftErr == nil {
|
||||
left = leftAbs
|
||||
}
|
||||
if rightErr == nil {
|
||||
right = rightAbs
|
||||
}
|
||||
return strings.EqualFold(filepath.Clean(left), filepath.Clean(right))
|
||||
}
|
||||
117
internal/targets/targets.go
Normal file
117
internal/targets/targets.go
Normal file
@@ -0,0 +1,117 @@
|
||||
package targets
|
||||
|
||||
import (
|
||||
"errors"
|
||||
"fmt"
|
||||
"os"
|
||||
"path/filepath"
|
||||
|
||||
"sgg-ai-skill-manager/internal/domain"
|
||||
)
|
||||
|
||||
type Target struct {
|
||||
ID string
|
||||
Name string
|
||||
SkillsDir string
|
||||
}
|
||||
|
||||
type Manager struct {
|
||||
Targets map[string]Target
|
||||
}
|
||||
|
||||
func New(targets map[string]Target) *Manager {
|
||||
return &Manager{Targets: targets}
|
||||
}
|
||||
|
||||
func DefaultTargets(home string) map[string]Target {
|
||||
return map[string]Target{
|
||||
"codex": {
|
||||
ID: "codex",
|
||||
Name: "Codex",
|
||||
SkillsDir: filepath.Join(home, ".codex", "skills"),
|
||||
},
|
||||
"claude": {
|
||||
ID: "claude",
|
||||
Name: "Claude",
|
||||
SkillsDir: filepath.Join(home, ".claude", "skills"),
|
||||
},
|
||||
}
|
||||
}
|
||||
|
||||
func (m *Manager) Install(skill domain.SkillState, targetID string) (domain.SkillState, error) {
|
||||
target, ok := m.Targets[targetID]
|
||||
if !ok {
|
||||
return skill, fmt.Errorf("unknown target %s", targetID)
|
||||
}
|
||||
if _, err := os.Stat(skill.LocalPath); err != nil {
|
||||
return skill, fmt.Errorf("local skill path is not accessible: %w", err)
|
||||
}
|
||||
if skill.InstalledTargets == nil {
|
||||
skill.InstalledTargets = map[string]domain.InstalledTarget{}
|
||||
}
|
||||
if err := os.MkdirAll(target.SkillsDir, 0o755); err != nil {
|
||||
return skill, err
|
||||
}
|
||||
linkPath := filepath.Join(target.SkillsDir, skill.Repo)
|
||||
if _, err := os.Lstat(linkPath); err == nil {
|
||||
actual, readErr := ReadJunctionTarget(linkPath)
|
||||
if readErr == nil && samePath(actual, skill.LocalPath) {
|
||||
skill.InstalledTargets[targetID] = installedTarget(linkPath, skill.LocalPath)
|
||||
return skill, nil
|
||||
}
|
||||
return skill, fmt.Errorf("target path conflict: %s", linkPath)
|
||||
} else if !errors.Is(err, os.ErrNotExist) {
|
||||
return skill, err
|
||||
}
|
||||
if err := CreateJunction(linkPath, skill.LocalPath); err != nil {
|
||||
return skill, err
|
||||
}
|
||||
skill.InstalledTargets[targetID] = installedTarget(linkPath, skill.LocalPath)
|
||||
return skill, nil
|
||||
}
|
||||
|
||||
func (m *Manager) Uninstall(skill domain.SkillState, targetID string) (domain.SkillState, error) {
|
||||
record, ok := skill.InstalledTargets[targetID]
|
||||
if !ok {
|
||||
return skill, nil
|
||||
}
|
||||
actual, err := ReadJunctionTarget(record.Path)
|
||||
if err != nil {
|
||||
return skill, fmt.Errorf("cannot verify junction target: %w", err)
|
||||
}
|
||||
if !samePath(actual, record.TargetPath) || !samePath(actual, skill.LocalPath) {
|
||||
return skill, fmt.Errorf("junction target mismatch: %s", record.Path)
|
||||
}
|
||||
if err := RemoveJunction(record.Path); err != nil {
|
||||
return skill, err
|
||||
}
|
||||
delete(skill.InstalledTargets, targetID)
|
||||
return skill, nil
|
||||
}
|
||||
|
||||
func (m *Manager) Status(skill domain.SkillState, targetID string) string {
|
||||
target, ok := m.Targets[targetID]
|
||||
if !ok {
|
||||
return "unknown"
|
||||
}
|
||||
linkPath := filepath.Join(target.SkillsDir, skill.Repo)
|
||||
actual, err := ReadJunctionTarget(linkPath)
|
||||
if errors.Is(err, os.ErrNotExist) {
|
||||
return "not_installed"
|
||||
}
|
||||
if err != nil {
|
||||
return "conflict"
|
||||
}
|
||||
if samePath(actual, skill.LocalPath) {
|
||||
return "installed"
|
||||
}
|
||||
return "conflict"
|
||||
}
|
||||
|
||||
func installedTarget(linkPath, targetPath string) domain.InstalledTarget {
|
||||
return domain.InstalledTarget{
|
||||
Path: linkPath,
|
||||
LinkType: "junction",
|
||||
TargetPath: targetPath,
|
||||
}
|
||||
}
|
||||
70
internal/targets/targets_test.go
Normal file
70
internal/targets/targets_test.go
Normal file
@@ -0,0 +1,70 @@
|
||||
package targets
|
||||
|
||||
import (
|
||||
"os"
|
||||
"path/filepath"
|
||||
"testing"
|
||||
|
||||
"sgg-ai-skill-manager/internal/domain"
|
||||
)
|
||||
|
||||
func TestInstallCreatesJunctionAndUninstallKeepsSource(t *testing.T) {
|
||||
root := t.TempDir()
|
||||
source := filepath.Join(root, "repo", "demo")
|
||||
if err := os.MkdirAll(source, 0o755); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if err := os.WriteFile(filepath.Join(source, "SKILL.md"), []byte("# Demo\n"), 0o644); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
manager := New(map[string]Target{
|
||||
"codex": {ID: "codex", Name: "Codex", SkillsDir: filepath.Join(root, "codex", "skills")},
|
||||
})
|
||||
skill := domain.SkillState{Org: "skills", Repo: "demo", LocalPath: source, InstalledTargets: map[string]domain.InstalledTarget{}}
|
||||
|
||||
installed, err := manager.Install(skill, "codex")
|
||||
if err != nil {
|
||||
t.Fatalf("Install returned error: %v", err)
|
||||
}
|
||||
link := filepath.Join(root, "codex", "skills", "demo")
|
||||
if _, err := os.Stat(filepath.Join(link, "SKILL.md")); err != nil {
|
||||
t.Fatalf("junction does not expose SKILL.md: %v", err)
|
||||
}
|
||||
if installed.InstalledTargets["codex"].TargetPath != source {
|
||||
t.Fatalf("installed target = %+v", installed.InstalledTargets["codex"])
|
||||
}
|
||||
|
||||
uninstalled, err := manager.Uninstall(installed, "codex")
|
||||
if err != nil {
|
||||
t.Fatalf("Uninstall returned error: %v", err)
|
||||
}
|
||||
if _, err := os.Stat(source); err != nil {
|
||||
t.Fatalf("source should remain after uninstall: %v", err)
|
||||
}
|
||||
if _, err := os.Lstat(link); !os.IsNotExist(err) {
|
||||
t.Fatalf("link should be removed, err=%v", err)
|
||||
}
|
||||
if _, ok := uninstalled.InstalledTargets["codex"]; ok {
|
||||
t.Fatal("codex install record should be removed")
|
||||
}
|
||||
}
|
||||
|
||||
func TestInstallRejectsExistingOrdinaryDirectory(t *testing.T) {
|
||||
root := t.TempDir()
|
||||
source := filepath.Join(root, "repo", "demo")
|
||||
link := filepath.Join(root, "codex", "skills", "demo")
|
||||
if err := os.MkdirAll(source, 0o755); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if err := os.MkdirAll(link, 0o755); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
manager := New(map[string]Target{
|
||||
"codex": {ID: "codex", Name: "Codex", SkillsDir: filepath.Join(root, "codex", "skills")},
|
||||
})
|
||||
skill := domain.SkillState{Org: "skills", Repo: "demo", LocalPath: source, InstalledTargets: map[string]domain.InstalledTarget{}}
|
||||
|
||||
if _, err := manager.Install(skill, "codex"); err == nil {
|
||||
t.Fatal("Install returned nil error for ordinary directory conflict")
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user