fix: reuse saved credential for connection test
This commit is contained in:
@@ -158,7 +158,11 @@ func (s *Service) TestConnection(ctx context.Context, req domain.SaveConfigReque
|
||||
if err := config.Validate(cfg); err != nil {
|
||||
return domain.TestConnectionResult{}, err
|
||||
}
|
||||
client, err := s.remoteMaker(ctx, cfg, requestSecret(req))
|
||||
secret, err := s.resolveSecret(req)
|
||||
if err != nil {
|
||||
return domain.TestConnectionResult{}, err
|
||||
}
|
||||
client, err := s.remoteMaker(ctx, cfg, secret)
|
||||
if err != nil {
|
||||
return domain.TestConnectionResult{}, err
|
||||
}
|
||||
@@ -471,6 +475,13 @@ func requestSecret(req domain.SaveConfigRequest) string {
|
||||
return req.Password
|
||||
}
|
||||
|
||||
func (s *Service) resolveSecret(req domain.SaveConfigRequest) (string, error) {
|
||||
if secret := requestSecret(req); secret != "" {
|
||||
return secret, nil
|
||||
}
|
||||
return s.secrets.Get(req.Config.Gitea.CredentialKey, credentialUser(req.Config))
|
||||
}
|
||||
|
||||
func credentialUser(cfg domain.Config) string {
|
||||
if cfg.Gitea.AuthType == config.AuthToken {
|
||||
return "token"
|
||||
|
||||
Reference in New Issue
Block a user